Skip to content

Clean up warnings#1996

Merged
vmg merged 1 commit intolibgit2:developmentfrom
ethomson:warnings
Dec 9, 2013
Merged

Clean up warnings#1996
vmg merged 1 commit intolibgit2:developmentfrom
ethomson:warnings

Conversation

@ethomson
Copy link
Copy Markdown
Member

@ethomson ethomson commented Dec 9, 2013

Clean up some warnings:

  • hton* not declared when not using bswap.h
  • Unused variable removed
  • Unused function removed
  • No newline at end of tests/refs/branches/create.c
  • Include stdarg.h before trying to redefine va_copy
  • Added GIT_UNUSED in the blame harder tests

@ethomson ethomson mentioned this pull request Dec 9, 2013
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of hate changing any of our deps, but this is such a dumb change that I trust it won't adversely affect our ability to realize that these have changed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...also the original code was retarded

vmg pushed a commit that referenced this pull request Dec 9, 2013
@vmg vmg merged commit 65e9dc6 into libgit2:development Dec 9, 2013
phatblat pushed a commit to phatblat/libgit2 that referenced this pull request Sep 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants