Skip to content

protocol: basic support for multi_ack_detailed#1919

Merged
vmg merged 1 commit intodevelopmentfrom
cmn/multi-ack-detailed
Oct 30, 2013
Merged

protocol: basic support for multi_ack_detailed#1919
vmg merged 1 commit intodevelopmentfrom
cmn/multi-ack-detailed

Conversation

@carlosmn
Copy link
Member

This tells the server that we speak it, but we don't make use of its
extra information to determine if there's a better place to stop
negotiating.

In a somewhat-related change, reorder the capabilities so we ask for
them in the same order as git does.

Also take this opportunity to factor out a fairly-indented portion of
the negotiation logic.

This tells the server that we speak it, but we don't make use of its
extra information to determine if there's a better place to stop
negotiating.

In a somewhat-related change, reorder the capabilities so we ask for
them in the same order as git does.

Also take this opportunity to factor out a fairly-indented portion of
the negotiation logic.
@vmg
Copy link
Member

vmg commented Oct 30, 2013

Neat. Can I expect a PR to see actual multi_ack information used? :)

vmg pushed a commit that referenced this pull request Oct 30, 2013
protocol: basic support for multi_ack_detailed
@vmg vmg merged commit cc74534 into development Oct 30, 2013
@carlosmn
Copy link
Member Author

Neat. Can I expect a PR to see actual multi_ack information used? :)

Sure, just as soon as I make the revision walker accept commands mid-way though a walk.

@carlosmn carlosmn deleted the cmn/multi-ack-detailed branch November 5, 2013 21:26
@ben ben mentioned this pull request Feb 24, 2014
34 tasks
phatblat pushed a commit to phatblat/libgit2 that referenced this pull request Sep 13, 2014
protocol: basic support for multi_ack_detailed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants