Skip to content

Errors can happen during init, before git__n_inits is initialized, which leads to a failed assertion #3318

New issue
New issue
Closed
Closed
Errors can happen during init, before git__n_inits is initialized, which leads to a failed assertion#3318
Assignees
joshaber
Labels
bug
@joshaber

Description

@joshaber
joshaber
opened on Jul 21, 2015
  1. git__getenv: utf-8 aware env reader #3288 introduced git__getenv, which introduced a bit more error handling in environment lookup than we had before.
  2. In POSIX, git_libgit2_init calls init_once before incrementing git__n_inits. (

    libgit2/src/global.c

    Line 347 in 42156d5

    pthread_once(&_once_init, init_once);
    )
  3. init_once calls various other init functions: https://github.com/libgit2/libgit2/blob/42156d561723e92ffe597885719aa63abfe0795c/src/global.c#L334-338
  4. Some of those global init functions (namely git_sysdir_global_init) can error (

    libgit2/src/sysdir.c

    Line 34 in ea445e0

    if (error == GIT_ENOTFOUND) {
    ), which means we try to clear the last_error.
  5. Setting the last_error accesses git__global_state (

    libgit2/src/errors.c

    Line 108 in c7f9412

    if (GIT_GLOBAL->last_error != NULL) {
    ).
  6. git__global_state asserts that git__n_inits > 0 (

    libgit2/src/global.c

    Line 383 in 42156d5

    assert(git_atomic_get(&git__n_inits) > 0);
    )
  7. 💥 We fail the assertion.

Metadata

Metadata

Assignees

Labels

bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions