Convert travis-ci/appveyor to github actions by ygj6 · Pull Request #951 · libevent/libevent

ygj6 · 2020-01-21T14:27:22Z

Closes: #945

cmake/CodeCoverage.cmake

CMAKE_C_COMPILER_ID is AppleClang on mac. The command make verify_coverage will fail unless you change line 78 in cmake/CodeCoverage.cmake.

Checking CMAKE_BUILD_TYPE on lines 83-85 is redundant because it is already done on lines 186-188 in CMakeLists.txt, and it cause a warning when CMAKE_BUILD_TYPE is set to 'debug'.

The command lcov --remove always treats the output as an absolute path, so we need pass it a full path.

test-export/test-export.py

Supports all versions of Visual Studio.

cmake/AddEventLibrary.cmake

Before setting rpath:

$ ldd /usr/local/lib/libevent_extra-2.2.so.1.0.0
linux-vdso.so.1 =>  (0x00007ffc359fd000)
libachk.so => /lib/libachk.so (0x00007fbf96c91000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fbf96a74000)
libevent_core-2.2.so.1 => not found
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fbf966aa000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fbf964a6000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fbf9629e000)
/lib64/ld-linux-x86-64.so.2 (0x00005593976fb000)

After setting rpath:

$ ldd /usr/local/lib/libevent_extra-2.2.so.1.0.0
linux-vdso.so.1 =>  (0x00007fffd03b7000)
libachk.so => /lib/libachk.so (0x00007ff9a363d000)
libevent_core-2.2.so.1 => /usr/local/lib/libevent_core-2.2.so.1 (0x00007ff9a3406000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ff9a31e9000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ff9a2e1f000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007ff9a2c1b000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007ff9a2a13000)
/lib64/ld-linux-x86-64.so.2 (0x0000556261411000)

doxygen

We need do some settings for libevent/libevent and libevent/doc:
First, generate the keys:
ssh-keygen -f libevent-deploy-key # will generate libevent-deploy-key and libevent-deploy-key.pub

Open https://github.com/libevent/libevent/settings/secrets -> Add new secrets
Name input LIBEVENT_DEPLOY_PRI
Value input content of libevent-deploy-key

Open https://github.com/libevent/doc/settings/keys -> Add deploy key
Title input LIBEVENT_DEPLOY_PUB
Key input content of libevent-deploy-key.pub

.github/workflows/coverage.yml

azat · 2020-01-21T14:39:42Z

I'm seeing that common_timeout fails, should be marked with TT_RETRIABLE

.github/workflows/macos.yml

.github/workflows/linux.yml

azat · 2020-01-21T14:49:49Z

@ygj6 great job! how long does it takes now on github actions?

ygj6 · 2020-01-21T15:24:03Z

About 15min in my morning (maybe your evening), but it is very slow and easy to fail in the evening. Just my personal feeling.

.github/workflows/coverage.yml

azat · 2020-01-22T08:00:08Z

.github/workflows/doxygen.yml

+
+    - name: Deploy Documentation
+      env:
+        LIBEVENT_DEPLOY_PRI: ${{ secrets.LIBEVENT_DEPLOY_PRI }}


A was talking about this variable, is it available for PRs? (I couldn't find anything in documentation)

#951 (comment)
‘secrets.LIBEVENT_DEPLOY_PRI’ is defined by myself.

Indeed, the libevent repo will need the same, and my question is will these secrete variable will be available to the PRs?

For example, in travis-ci encrypted variables a not available to the PRs:

Encrypted environment variables are not available to pull requests from forks due to the security risk of exposing such information to unknown code.

doxygen workflow is not applicable for PRs. And the workflow runs only on push events, not pull_request events.

on: push: branches: - master

The workflow will be triggered if PR is merged.

I also test this in a example.

doxygen workflow is not applicable for PRs.

Ok, just out of curiosity do you know if user-defined secrets available for the PRs?

I'm not sure. I will keep track of this issue, maybe I am missing something now.

ygj6 · 2020-01-22T12:52:46Z

I made some modifications:

cache on windows

actions/cache@v1.0.3 has some bugs on windows-2019, and actions/cache@v1.1.0 has some bugs on windows-2016. So I divided Windows-2016 and Windows-2019 into two jobs.

parallel test

Parallel testing is still likely to fail, so I deleted several CTEST_PARALLEL_LEVEL.

azat · 2020-01-22T21:21:05Z

@ygj6 any other known issues? or ready for merge?

ygj6 · 2020-01-23T07:36:44Z

I'm seeing that common_timeout fails, should be marked with TT_RETRIABLE

I added some codes like make test || make test to ensure that jobs can be retried if it fails.

ygj6 · 2020-01-23T07:55:23Z

In the last force-push, I deleted the branch TODO in the workflow, which exists only in my repository.
I think this PR can be merged.

azat · 2020-01-23T18:24:01Z

Ok, are you ok with my push (maybe --force) into your TODO branch?

azat · 2020-01-23T18:33:18Z

make test || make test

But this will retry all tests, while we need only few

Refs: libevent#951 (comment)

azat · 2020-01-23T18:41:34Z

My topic branch against your PR is github-actions

Refs: libevent#951 (comment)

ygj6 · 2020-01-24T09:26:16Z

are you ok with my push (maybe --force) into your TODO branch?

OK, no problem.

* github-actions: Update badges (drop travis-ci and appveyor) Drop travis-ci CI Drop appveyor CI github actions: test and coverage github actions: doxygen Ignore truthy in yamllint (for github-actions) test: mark common_timeout as retriable cmake: set rpath for libraries on linux test-export: compatible with all versions of visual studio coverage: 'lcov --remove' need full path

* github-actions-v2: travis: disable doxygen and coveralls, in favor of github actions github actions: test and coverage github actions: doxygen Ignore truthy in yamllint (for github-actions) test: mark common_timeout as retriable cmake: set rpath for libraries on linux test-export: compatible with all versions of visual studio coverage: 'lcov --remove' need full path

azat · 2020-01-26T23:04:58Z

@ygj6 merged (thanks a lot for looking into this!)

P.S. I decided to leave the travis-ci (with disabled coveralls/doxygem)/appveyor for awhile

Actually right now github's VMs is better then travis/appveyor.

Fixes: 28eb0d9 ("github actions looks good - drop travis/appveyor (libevent#951)")

azat reviewed Jan 21, 2020

View reviewed changes

.github/workflows/coverage.yml Outdated Show resolved Hide resolved

azat reviewed Jan 21, 2020

View reviewed changes

.github/workflows/macos.yml Outdated Show resolved Hide resolved

azat reviewed Jan 21, 2020

View reviewed changes

.github/workflows/linux.yml Outdated Show resolved Hide resolved

azat reviewed Jan 21, 2020

View reviewed changes

.github/workflows/coverage.yml Outdated Show resolved Hide resolved

azat reviewed Jan 22, 2020

View reviewed changes

ygj6 force-pushed the TODO branch from 734a204 to 8a7d5aa Compare January 22, 2020 12:23

ygj6 force-pushed the TODO branch 2 times, most recently from f3c1ac4 to 6611f45 Compare January 23, 2020 07:14

ygj6 force-pushed the TODO branch 2 times, most recently from d9af6a3 to 8aa973f Compare January 23, 2020 07:47

azat added a commit to azat/libevent that referenced this pull request Jan 23, 2020

test: mark common_timeout as retriable

63a5cb4

Refs: libevent#951 (comment)

ygj6 and others added 4 commits January 24, 2020 07:52

coverage: 'lcov --remove' need full path

1a99f9b

test-export: compatible with all versions of visual studio

9adc9f1

cmake: set rpath for libraries on linux

ce8be23

test: mark common_timeout as retriable

f6d7992

Refs: libevent#951 (comment)

Ignore truthy in yamllint (for github-actions)

cf379ec

azat force-pushed the TODO branch from 8aa973f to cc18237 Compare January 26, 2020 18:42

ygj6 and others added 3 commits January 27, 2020 01:50

github actions: doxygen

d151968

github actions: test and coverage

84bb2c1

travis: disable doxygen and coveralls, in favor of github actions

19a5516

azat force-pushed the TODO branch from cc18237 to 19a5516 Compare January 26, 2020 22:55

azat merged commit 19a5516 into libevent:master Jan 26, 2020

azat added a commit that referenced this pull request May 4, 2020

github actions looks good - drop travis/appveyor (#951)

28eb0d9

Actually right now github's VMs is better then travis/appveyor.

azat added a commit to azat/libevent that referenced this pull request May 5, 2020

Do not ignore anything in .github

f3e911e

Fixes: 28eb0d9 ("github actions looks good - drop travis/appveyor (libevent#951)")

Conversation

ygj6 commented Jan 21, 2020 • edited by azat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

azat commented Jan 21, 2020

Uh oh!

Uh oh!

Uh oh!

azat commented Jan 21, 2020

Uh oh!

ygj6 commented Jan 21, 2020

Uh oh!

Uh oh!

azat Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

ygj6 Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

azat Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

ygj6 Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

azat Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

ygj6 Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

ygj6 commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azat commented Jan 22, 2020

Uh oh!

ygj6 commented Jan 23, 2020

Uh oh!

ygj6 commented Jan 23, 2020

Uh oh!

azat commented Jan 23, 2020

Uh oh!

azat commented Jan 23, 2020

Uh oh!

azat commented Jan 23, 2020

Uh oh!

ygj6 commented Jan 24, 2020

Uh oh!

azat commented Jan 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

ygj6 commented Jan 21, 2020 •

edited by azat

Loading

ygj6 commented Jan 22, 2020 •

edited

Loading