Enable kqueue for APPLE targets#849
Merged
azat merged 1 commit intolibevent:masterfrom Jul 2, 2019
keith:ks/apple-kqueue
Merged
Enable kqueue for APPLE targets#849azat merged 1 commit intolibevent:masterfrom keith:ks/apple-kqueue
azat merged 1 commit intolibevent:masterfrom
keith:ks/apple-kqueue
Conversation
The CMAKE_CROSSCOMPILING variable is not set for Apple targets seemingly because of cmake implementation details (more info https://cmake.org/cmake/help/latest/variable/CMAKE_CROSSCOMPILING.html). Since Apple targets have working kqueue implementations this check makes sure we enable it always when those are the targets, without users having to explicitly set EVENT__HAVE_WORKING_KQUEUE
Member
|
Applied, thanks! |
Contributor
Author
|
Thanks! |
rebello95
added a commit
to rebello95/envoy
that referenced
this pull request
Jul 2, 2019
Pulls in the change added by libevent/libevent#849 to fix envoyproxy/envoy-mobile#215. Signed-off-by: Michael Rebello <mrebello@lyft.com>
mattklein123
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Jul 3, 2019
Pulls in the change added by libevent/libevent#849 to fix envoyproxy/envoy-mobile#215. Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 3, 2019
Updating Envoy to include envoyproxy/envoy#7453 (and subsequently libevent/libevent#849), which should fix the performance issues we're seeing on iOS. Resolves #215. Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 3, 2019
Updating Envoy to include envoyproxy/envoy#7453 (and subsequently libevent/libevent#849), which should fix the performance issues we're seeing on iOS. Resolves #215.
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Updating Envoy to include #7453 (and subsequently libevent/libevent#849), which should fix the performance issues we're seeing on iOS. Resolves envoyproxy/envoy-mobile#215. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Updating Envoy to include #7453 (and subsequently libevent/libevent#849), which should fix the performance issues we're seeing on iOS. Resolves envoyproxy/envoy-mobile#215. Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMAKE_CROSSCOMPILING variable is not set for Apple targets seemingly
because of cmake implementation details (more info
https://cmake.org/cmake/help/latest/variable/CMAKE_CROSSCOMPILING.html).
Since Apple targets have working kqueue implementations this check makes
sure we enable it always when those are the targets, without users
having to explicitly set EVENT__HAVE_WORKING_KQUEUE