Make all zero values have .RR().Data == ""#166
Merged
mholt merged 1 commit intolibdns:masterfrom Apr 20, 2025
Merged
Conversation
.RR().Data == ""
Collaborator
Author
|
Hmm, I suppose that this really should apply to the zero values for all |
mholt
previously approved these changes
Apr 19, 2025
Contributor
mholt
left a comment
There was a problem hiding this comment.
Thanks for this! I hadn't thought about this 😅 I did have one nit, but it's totally bikeshedding. Just wanted your thoughts on it. I'm good to merge it either way.
d1ecf5c to
ed34471
Compare
ed34471 to
e1d6c55
Compare
Collaborator
Author
|
Ok, I've rebased onto |
gucci-on-fleek
added a commit
to gucci-on-fleek/libdns-rfc2136
that referenced
this pull request
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Noticed in libdns/rfc2136#9 (comment))
The
Address.IPfield is allowed to be zero-initialized for use inDeleteRecords:libdns/libdns.go
Lines 200 to 205 in 5ab1d4d
Currently, calling
.RR()on such anAddressgivesrr.Data == "invalid IP", but this is a fairly surprising zero value, so this PR changes this to use the more conventional"".