Add support for NamedValueChecker interface#640
Closed
cyberdelia wants to merge 1 commit intolib:masterfrom
cyberdelia:named-value-checker
Closed
Add support for NamedValueChecker interface#640cyberdelia wants to merge 1 commit intolib:masterfrom cyberdelia:named-value-checker
cyberdelia wants to merge 1 commit intolib:masterfrom
cyberdelia:named-value-checker
Conversation
ainar-g
reviewed
Oct 11, 2017
Contributor
ainar-g
left a comment
There was a problem hiding this comment.
Just leaving some suggestions, waiting for others to chime in.
Contributor
Author
|
@ainar-g Good points, made the appropriate changes. |
Contributor
|
@cyberdelia Thanks. I hope @tamird and @mjibson will approve it. |
ainar-g
approved these changes
Oct 18, 2017
tamird
pushed a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
tamird
added a commit
that referenced
this pull request
Apr 27, 2023
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes. Close #640.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the new NamedValueChecker interface available in go 1.9.
This will allow to pass an array or a slice directly as an argument.