conn#readReadyForQuery(): on error (E) message throw that specific error#1136
Closed
Al2Klimov wants to merge 1 commit intolib:masterfrom
Closed
conn#readReadyForQuery(): on error (E) message throw that specific error#1136Al2Klimov wants to merge 1 commit intolib:masterfrom
Al2Klimov wants to merge 1 commit intolib:masterfrom
Conversation
not a generic one, so that the application can decide how to handle it. Sure it is an "unexpected message", but not a protocol error: > A frontend must be prepared to accept ErrorResponse and NoticeResponse > messages whenever it is expecting any other type of message. -- https://www.postgresql.org/docs/current/protocol-flow.html
rafiss
reviewed
Sep 22, 2023
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
thanks for your contribution! is there a way you can test this change?
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
Look, @rafiss, @log1-c has successfully tested this PR: Icinga/icingadb#620 (comment) 🎉 |
arp242
pushed a commit
that referenced
this pull request
Jan 3, 2026
From https://www.postgresql.org/docs/current/protocol-flow.html : > A frontend must be prepared to accept ErrorResponse and NoticeResponse > messages whenever it is expecting any other type of message. From #1136
arp242
pushed a commit
that referenced
this pull request
Jan 3, 2026
From https://www.postgresql.org/docs/current/protocol-flow.html : > A frontend must be prepared to accept ErrorResponse and NoticeResponse > messages whenever it is expecting any other type of message. From #1136
arp242
added a commit
that referenced
this pull request
Jan 3, 2026
From https://www.postgresql.org/docs/current/protocol-flow.html : > A frontend must be prepared to accept ErrorResponse and NoticeResponse > messages whenever it is expecting any other type of message. From #1136 Co-authored-by: Alexander A. Klimov <alexander.klimov@icinga.com>
Collaborator
|
Thanks; merged it via #1220 (I had to resolve a conflict, and editing is disabled on this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not a generic one, so that the application can decide how to handle it. Sure it is an "unexpected message", but not a protocol error:
-- https://www.postgresql.org/docs/current/protocol-flow.html
fixes Icinga/icingadb#478