Conversation
…for level-test until PR is accepted, added bundle.js
|
The thing is, that test is depending on approximateSize. You cannot really make it run without approximateSize. |
|
So, we need:
|
|
Ok, it is now completely working: |
|
What is also missing is:
|
|
@jez0990 could you please mess with the Makefile to write an automated build of the package? |
|
Ok, it just remains the README to be fixed! |
|
I implemented the logic for building a working levelgraph bundle in the Makefile. However I do not like the end-user API: I'll prefer to have a static bundle that do not expose |
|
The whole LevelGraph with all dependencies is 60KB minified and gzipped. It's not that bad :). |
|
This is great :) it sucks that I've not had any time to look at this over the last week though! I didn't know about Browserify's external requires until reading your commit just now but I guess they don't lend themselves to an elegant module interface. How about just exporting a function in the provided build with the default options so you can do And advanced users can follow the Make step you wrote if you only put it in the readme...? This would need a file And the new Make step: Does that sound sensible? |
|
Ha :) |
|
ahahhaha we had the same idea mostly at the same time. |
|
Looks great! May I delete the branch? |
|
Done :) |
All bar 2 tests are working now. I stopped "should order two conditions based on their size (bis)" from running in the browser altogether. I've given up on the variablesMask approach for now - I'm not sure it would have actually worked for that particular test anyway.