Skip to content

Add support for ACME Profiles#473

Merged
aarongable merged 6 commits into
mainfrom
acme-profiles
Aug 22, 2024
Merged

Add support for ACME Profiles#473
aarongable merged 6 commits into
mainfrom
acme-profiles

Conversation

@aarongable

Copy link
Copy Markdown
Contributor

Fixes #471

@aarongable aarongable force-pushed the acme-profiles branch 2 times, most recently from a5b345c to baeaab5 Compare August 21, 2024 17:17
@aarongable aarongable merged commit e08dd94 into main Aug 22, 2024
@aarongable aarongable deleted the acme-profiles branch August 22, 2024 15:57
@cpu cpu mentioned this pull request Jan 23, 2025
wallrj pushed a commit to wallrj/cert-manager that referenced this pull request May 29, 2025
See letsencrypt/pebble#473

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj pushed a commit to wallrj/cert-manager that referenced this pull request Jun 3, 2025
See letsencrypt/pebble#473

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj pushed a commit to wallrj/cert-manager that referenced this pull request Jun 3, 2025
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
(cherry picked from commit 72f58b7)

- Fix some unit tests
- Move the debug log message
- Catch errors due to ACME profiles not being supported by the ACME server
- Configure Pebble with ACME profiles. See letsencrypt/pebble#473
- Improve wrapping of CRD field help
- make generate-crds
- make fix-golangci-lint

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj pushed a commit to wallrj/cert-manager that referenced this pull request Jun 3, 2025
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
(cherry picked from commit 72f58b7)

- Fix some unit tests
- Move the debug log message
- Catch errors due to ACME profiles not being supported by the ACME server
- Configure Pebble with ACME profiles. See letsencrypt/pebble#473
- Improve wrapping of CRD field help
- make generate-crds
- make fix-golangci-lint

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj pushed a commit to wallrj/cert-manager that referenced this pull request Jun 4, 2025
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
(cherry picked from commit 72f58b7)

- Fix some unit tests
- Move the debug log message
- Catch errors due to ACME profiles not being supported by the ACME server
- Configure Pebble with ACME profiles. See letsencrypt/pebble#473
- Improve wrapping of CRD field help
- make generate-crds
- make fix-golangci-lint

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj pushed a commit to wallrj/cert-manager that referenced this pull request Jun 4, 2025
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
(cherry picked from commit 72f58b7)

- Fix some unit tests
- Move the debug log message
- Catch errors due to ACME profiles not being supported by the ACME server
- Configure Pebble with ACME profiles. See letsencrypt/pebble#473
- Improve wrapping of CRD field help
- make generate-crds
- make fix-golangci-lint

Signed-off-by: Richard Wall <richard.wall@cyberark.com>

Fix typo

Signed-off-by: Richard Wall <richard.wall@cyberark.com>

Use a shorter argument name

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
kwatson added a commit to kwatson/letsencrypt-pebble that referenced this pull request Jun 9, 2025
* 'main' of https://github.com/letsencrypt/pebble: (35 commits)
  add overriding of ARI response (letsencrypt#501)
  wfe: fix a race in `orderForDisplay` (letsencrypt#500)
  Bump golang.org/x/ dependencies (letsencrypt#499)
  currectly triggers BadSignatureAlgorithmProblem at JWS parse time (letsencrypt#492)
  use newer validation subdomain for dns-account-01 (fix CI eggsampler/acme error) (letsencrypt#498)
  Orders don't have a "deactivated" status. (letsencrypt#301)
  Update golangci-lint (letsencrypt#488)
  build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5 (letsencrypt#487)
  Truncate ARI timestamps to millisecond resolution (letsencrypt#485)
  return logical and compliant ARI windows for expiring certs (letsencrypt#484)
  Update dependencies (letsencrypt#481)
  docs: rm mention of subproblems being unimpl'd (letsencrypt#479)
  Fix(NOISSUE): Fix docker compose file example in README.md (letsencrypt#475)
  Add support for ACME Profiles (letsencrypt#473)
  Simplify KU, EKU, and SKID fields of issued certs (letsencrypt#472)
  Update golangci-lint to 1.60.2 (letsencrypt#474)
  Update /x/net for compatibility with go1.23 (letsencrypt#470)
  Reject extra command line args and fix README invocation (letsencrypt#467)
  Document exposing API and management ports when not using docker-compose.yaml (letsencrypt#465)
  Implement latest draft-ietf-acme-ari spec (letsencrypt#461)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support profile selection

2 participants