Add eab key example that enforces base64url#428
Closed
j0ru wants to merge 1 commit into
Closed
Conversation
The acme rfc states that clients should interpret supplied eab keys as base64url. To encourage that behaviour, this commit adds a key to the example configuration that is only decodable by base64url.
Contributor
|
pulled into #459 to use in EAB integration test |
mcpherrinm
added a commit
that referenced
this pull request
May 1, 2024
During the go-jose/v4 upgrade, I accidentally required the same signature sets for EAB as for the account keys, which is incorrect. This allows the correct MAC-based algorithms. It drops the custom algorithm checks, which are now unreachable as go-jose will enforce the algorithms. This also adds a new EAB key to Pebble's test config which explicitly has base64url characters, from #428 Fixes #455 --------- Co-authored-by: Folke Gleumes <folke@gleumes.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acme rfc states that clients should interpret supplied eab keys as base64url. To encourage that behavior, this commit adds a key to the example configuration that is only decodable by base64url.