Remove CommonName from issued certificates#420
Merged
Conversation
The Baseline requirements now says Common Name is "Not Recommended" for subscriber server certificates, so this follows that recommendation.
188f343 to
0172f86
Compare
jsha
approved these changes
Feb 20, 2024
jsha
left a comment
Contributor
There was a problem hiding this comment.
Thanks! (and sorry for the delay)
This was referenced Feb 24, 2024
srhb
added a commit
to DBCDK/faythe
that referenced
this pull request
Jan 24, 2025
See letsencrypt/pebble#420 for the original CN disablement, which is currently superseded by various ongoing profile work, some of which is documented here: https://letsencrypt.org/2025/01/09/acme-profiles/
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
May 30, 2025
Pebble drops the CN since letsencrypt/pebble#420 Support may be added back in letsencrypt/pebble#491 Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
May 30, 2025
It drops the CN: - letsencrypt/pebble#420 And it drops any other KUs that are in the CSR. Make sure that Digital Signature is the only KU we request so that the CSR and the signed certificate match during the verification at the end of the test. - letsencrypt/pebble#472 - https://github.com/letsencrypt/pebble/releases/tag/v2.7.0 Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
Jun 1, 2025
Pebble drops the CN since letsencrypt/pebble#420 Support may be added back in letsencrypt/pebble#491 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 487a54f)
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
Jun 1, 2025
It drops the CN: - letsencrypt/pebble#420 And it drops any other KUs that are in the CSR. Make sure that Digital Signature is the only KU we request so that the CSR and the signed certificate match during the verification at the end of the test. - letsencrypt/pebble#472 - https://github.com/letsencrypt/pebble/releases/tag/v2.7.0 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 0c50492)
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
Jun 1, 2025
Pebble drops the CN since letsencrypt/pebble#420 Support may be added back in letsencrypt/pebble#491 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 487a54f)
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
Jun 1, 2025
It drops the CN: - letsencrypt/pebble#420 And it drops any other KUs that are in the CSR. Make sure that Digital Signature is the only KU we request so that the CSR and the signed certificate match during the verification at the end of the test. - letsencrypt/pebble#472 - https://github.com/letsencrypt/pebble/releases/tag/v2.7.0 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 0c50492)
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
Jun 1, 2025
Pebble drops the CN since letsencrypt/pebble#420 Support may be added back in letsencrypt/pebble#491 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 487a54f)
wallrj
pushed a commit
to wallrj/cert-manager
that referenced
this pull request
Jun 1, 2025
It drops the CN: - letsencrypt/pebble#420 And it drops any other KUs that are in the CSR. Make sure that Digital Signature is the only KU we request so that the CSR and the signed certificate match during the verification at the end of the test. - letsencrypt/pebble#472 - https://github.com/letsencrypt/pebble/releases/tag/v2.7.0 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 0c50492)
hjoshi123
pushed a commit
to hjoshi123/cert-manager
that referenced
this pull request
Jul 6, 2025
Pebble drops the CN since letsencrypt/pebble#420 Support may be added back in letsencrypt/pebble#491 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 487a54f)
hjoshi123
pushed a commit
to hjoshi123/cert-manager
that referenced
this pull request
Jul 6, 2025
It drops the CN: - letsencrypt/pebble#420 And it drops any other KUs that are in the CSR. Make sure that Digital Signature is the only KU we request so that the CSR and the signed certificate match during the verification at the end of the test. - letsencrypt/pebble#472 - https://github.com/letsencrypt/pebble/releases/tag/v2.7.0 Signed-off-by: Richard Wall <richard.wall@cyberark.com> (cherry picked from commit 0c50492)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Baseline requirements now says Common Name is "Not Recommended" for
subscriber server certificates, so this follows that recommendation.