Docker: expose ports 14000 and 15000 in the pebble image#279
Conversation
|
Hi @sergioaugrod 👋 Thanks for opening a PR!
Can you explain a little bit more about this part? My understanding was that the |
|
Hi @cpu. You are right. My problem is that Gitlab CI HealthCheck checks which ports are exposed from the container by default and If I don't expose any port in my Dockerfile, then the pipeline will fail. Currently, I can't expose ports in my There is a discussion about this here: https://gitlab.com/gitlab-org/gitlab-runner/issues/2460 Despite this very specific problem of mine, would it be nice to have it in Dockerfile to improve the documentation? Thank you! |
cpu
left a comment
There was a problem hiding this comment.
Thanks for the additional info. I think it makes sense to accept this PR. I think the additional metadata improves the clarity of the Docker environment. I hope Gitlab fixes their bug since it seems like something that shouldn't be required but I'm OK with landing this fix since it has benefits beyond just Gitlab CI.
Thanks again!
With this PR, I’m adding a layer to the final image to expose the apps ports. This fixes the visibility of the applications when it’s run as a service in GitLab CI. There was a previous PR (#279) where these ports were added. However, during the CI/CD update (#444) they were removed, likely to keep the Dockerfile more universal.
Hello,
I exposed ports 14000 and 15000 in the pebble image. I believe this improves readability of Dockerfile and this will help me to run the image on GitlabCI.
Does that make sense to you?
Thank you!