bdns: remove logDNSError #8445
Merged
bdns: remove logDNSError #8445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had some special casing for the "id mismatch" error we were tracking for a while. We've resolved that issue by switching to DoH and now see 0 instances of "id mismatch." However, it's still been occasionally useful to see the detailed DNS errors, so I'm keeping a simplified log line.
c4a8284 to
a3f6107
Compare
aarongable
previously approved these changes
Oct 21, 2025
bdns/dns.go
Outdated
| "resolver": chosenServerIP, | ||
| }).Inc() | ||
| } | ||
| queryType := dns.TypeToString[m.Question[0].Qtype] |
Member
There was a problem hiding this comment.
Since m.SetQuestion already sets m.SetQuestion(dns.Fqdn(hostname), qtype) and qtypeStr := dns.TypeToString[qtype], these should always be the same. Was there a reason to pull it from the message instead of reusing qtypeStr?
beautifulentropy
approved these changes
Oct 24, 2025
aarongable
approved these changes
Oct 27, 2025
aarongable
pushed a commit
that referenced
this pull request
Nov 6, 2025
This was accidentally deleted along with the idMismatchCounter in #8445. This is an alternative approach to #8474, and perhaps a reasonable default pattern for all stats registration in Boulder. For more on promauto, see its documentation: https://pkg.go.dev/github.com/prometheus/client_golang@v1.23.2/prometheus/promauto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had some special casing for the "id mismatch" error we were tracking for a while. We've resolved that issue by switching to DoH and now see 0 instances of "id mismatch." However, it's still been occasionally useful to see the detailed DNS errors, so I'm keeping a simplified log line.