Update certificate-transparency-go for bugfix#8160
Conversation
This updates to current `master`, bc7acd89f703743d050f5cd4a3b9746808e0fdae Notably, it includes a bug-fix to error handling in the HTTP client, which we found was hiding errors from CT logs, hindering our debugging. That fix is google/certificate-transparency-go#1695 No release has been tagged since this PR merged, so using the `master` commit. A few mutual dependencies used by both Boulder and ct-go are updated, including mysql, otel, and grpc.
| github.com/go-sql-driver/mysql v1.9.1 | ||
| github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da | ||
| github.com/google/certificate-transparency-go v1.3.1 | ||
| github.com/google/certificate-transparency-go v1.3.2-0.20250506133818-bc7acd89f703 |
There was a problem hiding this comment.
everything else is a consequence of this
|
Integration tests failing from what looks like an RPC issue Could be related to grpc update? Opened #8161 to isolate |
Trying to isolate failures from #8160
|
The actual errors are: This error string comes from the brand new endpointsharding.go. We use the "roundrobin" balancer, which was updated to use endpointsharding. So that's why we're getting a new error message. |
aarongable
left a comment
There was a problem hiding this comment.
I've reviewed all transitive dependency updates. There's an update to go-sql-driver/mysql, which we've historically wanted to be careful about, and which does network calls to the database. There's also the new opentelemetry.io/auto/sdk package, which does quite a bit of byte-slice parsing, compressing, and decompressing. I didn't see anything particularly worrisome in either package, but both are moderately complex and difficult to read.
This updates to current
master, bc7acd89f703743d050f5cd4a3b9746808e0fdaeNotably, it includes a bug-fix to error handling in the HTTP client, which we found was hiding errors from CT logs, hindering our debugging.
That fix is google/certificate-transparency-go#1695
No release has been tagged since this PR merged, so using the
mastercommit.A few mutual dependencies used by both Boulder and ct-go are updated, including mysql, otel, and grpc.