ARI: Store and reflect optional "replaces" value for Orders #8056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
Contributor
|
@beautifulentropy, this PR adds one or more new feature flags: StoreARIReplacesInOrders. As such, this PR must be accompanied by a review of the Let's Encrypt CP/CPS to ensure that our behavior both before and after this flag is flipped is compliant with that document. Please conduct such a review, then add your findings to the PR description in a paragraph beginning with "CPS Compliance Review:". |
aarongable
previously approved these changes
Mar 11, 2025
Contributor
aarongable
left a comment
There was a problem hiding this comment.
LGTM, this is really elegantly done. Just a few tiny comments.
jprenken
previously approved these changes
Mar 12, 2025
f0cbffd
aarongable
approved these changes
Mar 12, 2025
jprenken
approved these changes
Mar 12, 2025
commonism
added a commit
to commonism/acmetk
that referenced
this pull request
Oct 19, 2025
commonism
added a commit
to noahkw/acmetk
that referenced
this pull request
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8034
CPS Compliance Review: this change in no way impacts our CP/CPS compliance, it resolves an unintentional divergence from draft-ietf-acme-ari.
Deployment is being tracked in: IN-11106