ratelimit: Remove legacy registrations per IP implementation#7760
Merged
Conversation
52963aa to
884dc1f
Compare
884dc1f to
b51c916
Compare
aarongable
reviewed
Nov 18, 2024
aarongable
previously approved these changes
Nov 19, 2024
jprenken
reviewed
Nov 19, 2024
11 tasks
aarongable
previously approved these changes
Nov 19, 2024
| test.Assert(t, len(*acct.Contact) >= 1, "No contact field in account") | ||
| test.AssertEquals(t, (*acct.Contact)[0], "mailto:person@mail.com") | ||
| test.AssertEquals(t, acct.Agreement, "") | ||
| test.AssertEquals(t, acct.InitialIP.String(), "1.1.1.1") |
Contributor
There was a problem hiding this comment.
Might be worth preserving a single test that confirms that the WFE is hardcoding this to 0.0.0.0 now.
Member
Author
There was a problem hiding this comment.
We can't preserve this test unless we also preserve the code that marshals the corepb.Registration back into the core.Registration object we can show the subscriber.
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
jsha
approved these changes
Nov 19, 2024
aarongable
approved these changes
Nov 19, 2024
beautifulentropy
added a commit
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7671