WFE: Normalize SANs in NewOrder request#7554
Merged
Merged
Conversation
beautifulentropy
requested changes
Jun 20, 2024
Co-authored-by: Samantha Frank <hello@entropy.cat>
Co-authored-by: Samantha Frank <hello@entropy.cat>
beautifulentropy
previously approved these changes
Jun 20, 2024
aarongable
previously approved these changes
Jun 20, 2024
fc14a4a
beautifulentropy
previously approved these changes
Jun 20, 2024
beautifulentropy
requested changes
Jun 20, 2024
3 tasks
aarongable
reviewed
Jun 20, 2024
beautifulentropy
approved these changes
Jun 20, 2024
aarongable
approved these changes
Jun 20, 2024
pgporada
added a commit
that referenced
this pull request
Jun 20, 2024
In #7530, `wfe.NewOrder` [began constructing a rate limit transaction](https://github.com/letsencrypt/boulder/pull/7530/files#diff-3f950e720c205ce9fa8dea12c6fd7fd44272c2671f19d0e06962abfbea00d491R2340-R2344) with a precondition that all names must be lower-cased, however the actual implementation of the precondition was accidentally overlooked. This fix corrects that and adds a unit test to prevent a future regression. Other changes: - Only normalized names count towards max names limit - Only normalized names will be logged in the web.RequestEvent --------- Co-authored-by: Samantha Frank <hello@entropy.cat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7530,
wfe.NewOrderbegan constructing a rate limit transaction with a precondition that all names must be lower-cased, however the actual implementation of the precondition was accidentally overlooked. This fix corrects that and adds a unit test to prevent a future regression.Other changes: