build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625

dependabot · 2023-02-01T01:03:11Z

Bumps github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0.

Release notes

Sourced from github.com/go-sql-driver/mysql's releases.

Version 1.7

Changes:

Drop support of Go 1.12 (#1211)

Refactoring (*textRows).readRow in a more clear way (#1230)

util: Reduce boundary check in escape functions. (#1316)

enhancement for mysqlConn handleAuthResult (#1250)

New Features:

support Is comparison on MySQLError (#1210)

return unsigned in database type name when necessary (#1238)

Add API to express like a --ssl-mode=PREFERRED MySQL client (#1370)

Add SQLState to MySQLError (#1321)

Bugfixes:

Fix parsing 0 year. (#1257)

Version 1.6.0

Major Release

Migrate the CI service from travis-ci to GitHub Actions (#1176, #1183, #1190)

NullTime is deprecated (#960, #1144)

Reduce allocations when building SET command (#1111)

Performance improvement for time formatting (#1118)

Performance improvement for time parsing (#1098, #1113)

See CHANGELOG.md for full details

Changelog

Sourced from github.com/go-sql-driver/mysql's changelog.

Version 1.7 (2022-11-29)

Changes:

Drop support of Go 1.12 (#1211)

Refactoring (*textRows).readRow in a more clear way (#1230)

util: Reduce boundary check in escape functions. (#1316)

enhancement for mysqlConn handleAuthResult (#1250)

New Features:

support Is comparison on MySQLError (#1210)

return unsigned in database type name when necessary (#1238)

Add API to express like a --ssl-mode=PREFERRED MySQL client (#1370)

Add SQLState to MySQLError (#1321)

Bugfixes:

Fix parsing 0 year. (#1257)

Version 1.6 (2021-04-01)

Changes:

Migrate the CI service from travis-ci to GitHub Actions (#1176, #1183, #1190)

NullTime is deprecated (#960, #1144)

Reduce allocations when building SET command (#1111)

Performance improvement for time formatting (#1118)

Performance improvement for time parsing (#1098, #1113)

New Features:

Implement driver.Validator interface (#1106, #1174)

Support returning uint64 from Valuer in ConvertValue (#1143)

Add json.RawMessage for converter and prepared statement (#1059)

Interpolate json.RawMessage as string (#1058)

Implements CheckNamedValue (#1090)

Bugfixes:

Stop rounding times (#1121, #1172)

Put zero filler into the SSL handshake packet (#1066)

Fix checking cancelled connections back into the connection pool (#1095)

Fix remove last 0 byte for mysql_old_password when password is empty (#1133)

Version 1.5 (2020-01-07)

Changes:

... (truncated)

Commits

5cee457 update changelog for Version 1.7 (#1376)
41dd159 Add AllowFallbackToPlaintext and TLS to config (#1370)
fa1e4ed Fix parsing 0 year. (#1257)
05bed83 Add CodeQL workflow for GitHub code scanning (#1369)
803c0e0 migrate set-output to the environment file (#1368)
a477f69 fix: benchmarkExecContext is unused (#1351)
0c62bb2 Go1.19 is released (#1350)
ad9fa14 Add SQLState to MySQLError (#1321)
eff3908 Move default packet size to constant (#1319)
90e813f Add go1.18 to test matrix (#1317)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.5.0 to 1.7.0. - [Release notes](https://github.com/go-sql-driver/mysql/releases) - [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md) - [Commits](go-sql-driver/mysql@v1.5.0...v1.7.0) --- updated-dependencies: - dependency-name: github.com/go-sql-driver/mysql dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

beautifulentropy · 2023-02-01T03:50:50Z

@pgporada heads up, we rolled 1.6.x back after experiencing connection churn in production.

pgporada · 2023-02-02T23:08:59Z

I was there, 84 years ago!

pgporada · 2023-02-02T23:10:12Z

Related #5437

pgporada · 2023-02-02T23:50:07Z

I think we're going to have the same issue with this upgrade as we did with 1.6.0. My eyes don't see any particular commits that change/improve either of the PRs found in #5437

jsha · 2023-02-02T23:54:47Z

One thing that's changed: we've stopped propagating cancellation to the SA.

aarongable · 2023-02-13T20:01:53Z

This PR was failing tests, due to a change in go-sql-driver/mysql which changed error messages, breaking our string-based .duplicate() function:

boulder/db/map.go

Lines 29 to 36 in 581ea05

    
           // duplicate returns true when the underlying error has a message with a prefix 
        
           // matching "Error 1062: Duplicate entry". This is the error prefixed returned 
        
           // by MariaDB when a duplicate row is to be inserted. 
        
           func (e ErrDatabaseOp) duplicate() bool { 
        
           	return strings.HasPrefix( 
        
           		e.Err.Error(), 
        
           		"Error 1062: Duplicate entry") 
        
           }

I have added one commit to this PR which updates map.go and map_test.go to have more resilient versions of both db.IsDuplicate and db.IsNoRows, so that future error message changes like this won't break those methods.

Please review ASAP so we can tag this with the release today, as planned last week.

beautifulentropy

Fantastic, I'm very happy to see these methods get implemented with errors.As/.Is instead of matching on the prefix.

db/map.go

…o 1.7.0 (#6625)" This reverts commit fdfea0d.

…" (#6660) This reverts commit fdfea0d. With a Go security release out this week we prefer to do a single release on the new Go version rather than trying to deploy the new go-sql-driver version.

….0 (#6625)" (#6660)" This reverts commit 0f2b47e.

This reverts #6660, and relands #6625.

dependabot bot requested a review from a team as a code owner February 1, 2023 01:03

dependabot bot requested a review from pgporada February 1, 2023 01:03

dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 1, 2023

Fix db.IsDuplicate to be more resilient

5c329ff

aarongable requested review from beautifulentropy and jsha February 13, 2023 20:01

beautifulentropy approved these changes Feb 13, 2023

View reviewed changes

pgporada reviewed Feb 13, 2023

View reviewed changes

db/map.go Show resolved Hide resolved

pgporada approved these changes Feb 13, 2023

View reviewed changes

aarongable merged commit fdfea0d into main Feb 13, 2023

aarongable deleted the dependabot/go_modules/github.com/go-sql-driver/mysql-1.7.0 branch February 13, 2023 21:35

jsha added a commit that referenced this pull request Feb 14, 2023

Revert "build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 t…

ffcef28

…o 1.7.0 (#6625)" This reverts commit fdfea0d.

aarongable added a commit that referenced this pull request Feb 14, 2023

Revert "Revert "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7…

f80973e

….0 (#6625)" (#6660)" This reverts commit 0f2b47e.

aarongable mentioned this pull request Feb 14, 2023

Reland "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0" #6662

Merged

beautifulentropy pushed a commit that referenced this pull request Feb 21, 2023

Reland "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0" (#6662)

85b146e

This reverts #6660, and relands #6625.

aarongable mentioned this pull request Sep 8, 2023

DB: Truncate timestamps to microseconds #7075

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625

build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625

Uh oh!

dependabot bot commented on behalf of github Feb 1, 2023

Uh oh!

beautifulentropy commented Feb 1, 2023

Uh oh!

pgporada commented Feb 2, 2023

Uh oh!

pgporada commented Feb 2, 2023

Uh oh!

pgporada commented Feb 2, 2023

Uh oh!

jsha commented Feb 2, 2023

Uh oh!

aarongable commented Feb 13, 2023

Uh oh!

beautifulentropy left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625

build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 #6625

Uh oh!

Conversation

dependabot bot commented on behalf of github Feb 1, 2023

Version 1.7

Version 1.6.0

Version 1.7 (2022-11-29)

Version 1.6 (2021-04-01)

Version 1.5 (2020-01-07)

Uh oh!

beautifulentropy commented Feb 1, 2023

Uh oh!

pgporada commented Feb 2, 2023

Uh oh!

pgporada commented Feb 2, 2023

Uh oh!

pgporada commented Feb 2, 2023

Uh oh!

jsha commented Feb 2, 2023

Uh oh!

aarongable commented Feb 13, 2023

Uh oh!

beautifulentropy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants