feat(report): add mutated files' properties#8
Merged
letFunny merged 6 commits intoletFunny:report-mutated-filesfrom Apr 5, 2024
Merged
Conversation
Author
|
/cc @letFunny |
letFunny
reviewed
Mar 7, 2024
Owner
letFunny
left a comment
There was a problem hiding this comment.
Did a first pass, I still have to look at the tests carefully but so far it is looking great.
letFunny
reviewed
Mar 11, 2024
added 2 commits
April 4, 2024 14:19
The paths with ``mutable: true`` property can be "mutated" with mutation scripts. Thus, the files matching those paths may have a different size and hash after the mutation scripts have been run. The report should reflect these changes by updating the entries of the mutated paths. Paths can also have the ``until: mutate`` property. This means that those files are available until the mutation scripts have been run and are not present in the final file system. Thus, they should not be part of the report either. This commit adds support for both -- it updates the changed properties of mutated files and makes sure not to add report entries for ``until: mutate``.
c266f70 to
f230c3b
Compare
letFunny
reviewed
Apr 4, 2024
letFunny
approved these changes
Apr 4, 2024
Owner
letFunny
left a comment
There was a problem hiding this comment.
Last change required :). I will merge it tomorrow, thanks!
Author
|
Updated the PR. I can raise the PR in the canonical/chisel repo if you want -- and then you can review/approve it there. |
letFunny
added a commit
that referenced
this pull request
Apr 16, 2024
The paths with ``mutable: true`` property can be "mutated" with mutation scripts. Thus, the files matching those paths may have a different size and hash after the mutation scripts have been run. The report should reflect these changes by updating the entries of the mutated paths. Paths can also have the ``until: mutate`` property. This means that those files are available until the mutation scripts have been run and are not present in the final file system. Thus, they should not be part of the report either. This commit adds support for both -- it updates the changed properties of mutated files and makes sure not to add report entries for ``until: mutate``.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paths with
mutable: trueproperty can be "mutated" with mutation scripts. Thus, the files matching those paths may have a different size and hash after the mutation scripts have been run. The report should reflect these changes by updating the entries of the mutated paths.Paths can also have the
until: mutateproperty. This means that those files are available until the mutation scripts have been run and are not present in the final file system. Thus, they should not be part of the report either.This commit adds support for both -- it updates the changed properties of mutated files and makes sure not to add report entries for
until: mutate.