fix: deprecate "chisel-v1" format support#16
Merged
letFunny merged 5 commits intoletFunny:deprecate-chisel-v1from Jul 29, 2024
Merged
fix: deprecate "chisel-v1" format support#16letFunny merged 5 commits intoletFunny:deprecate-chisel-v1from
letFunny merged 5 commits intoletFunny:deprecate-chisel-v1from
Conversation
Author
|
Raised in anticipation of the merging of the DB PRs. Not urgent. 🟢 |
763bea0 to
e0fc0f5
Compare
This commit depreciates support for the "chisel-v1" format in chisel.
Notably the following fields/values are no longer supported:
- The "chisel-v1" value for top-level field "format". Use "v1"
instead.
- The "<archive>.v1-public-keys" field. Use "<archive>.public-keys"
instead.
- The top-level "v1-public-keys" field. Use "public-keys" instead.
BREAKING CHANGE: New versions of chisel which includes this commit will
no longer support the "chisel-v1" format in chisel-releases. Either
update the "chisel.yaml" file in chisel-releases or use a lower
version which does not have this commit.
letFunny
requested changes
Jul 8, 2024
Owner
letFunny
left a comment
There was a problem hiding this comment.
Thanks Rafid, the PR is looking good, only some minor comments. Also, the commit message has a typo, "depreciate" -> "deprecate".
letFunny
approved these changes
Jul 26, 2024
Owner
letFunny
left a comment
There was a problem hiding this comment.
Thanks, only a couple of nits
internal/setup/setup_test.go
Outdated
| v1-public-keys: [extra-key] | ||
| default: true | ||
| v1-public-keys: | ||
| extra-key: |
Owner
There was a problem hiding this comment.
Does this key have any significance? extra-key seems to imply that it is different from a regular one.
Owner
There was a problem hiding this comment.
Can you add the v1-public-keys back? I only meant using the default key instead of implying that this is an extra one. I think having a complete example of chisel-v1 is still useful for reference.
letFunny
reviewed
Jul 29, 2024
letFunny
pushed a commit
that referenced
this pull request
Jul 29, 2024
This commit depreciates support for the "chisel-v1" format in chisel.
Notably the following fields/values are no longer supported:
- The "chisel-v1" value for top-level field "format". Use "v1"
instead.
- The "<archive>.v1-public-keys" field. Use "<archive>.public-keys"
instead.
- The top-level "v1-public-keys" field. Use "public-keys" instead.
BREAKING CHANGE: New versions of chisel which includes this commit will
no longer support the "chisel-v1" format in chisel-releases. Either
update the "chisel.yaml" file in chisel-releases or use a lower
version which does not have this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates support for the "chisel-v1" format in chisel. Notably, the following fields/values are no longer supported:
chisel-v1value for top-level fieldformat. Usev1instead.<archive>.v1-public-keysfield. Use<archive>.public-keysinstead.v1-public-keysfield. Usepublic-keysinstead.BREAKING CHANGE: New versions of chisel which includes this commit will no longer support the "chisel-v1" format in chisel-releases. Either update the "chisel.yaml" file in chisel-releases or use a older version which does not have this commit.