Skip to content

feat!: stop publishing @lerna/child-process#3909

Merged
JamesHenry merged 8 commits intolerna:mainfrom
fahslaj:chore/stop-publishing-child-process
Nov 22, 2023
Merged

feat!: stop publishing @lerna/child-process#3909
JamesHenry merged 8 commits intolerna:mainfrom
fahslaj:chore/stop-publishing-child-process

Conversation

@fahslaj
Copy link
Copy Markdown
Contributor

@fahslaj fahslaj commented Nov 21, 2023

Description

Move @lerna/child-process into a private library.

Motivation and Context

@lerna/child-process is by no means the best child process tool in the ecosystem. With Lerna v8, we will recommend that users that were previously depending directly on @lerna/child-process to use other tools instead. This also allows us to more easily update the underlying implementation of @lerna/child-process as we will no longer need to worry about breaking changes by updating dependencies like execa.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amorscher
Copy link
Copy Markdown
Contributor

@fahslaj ok I think we have to discuss how we proceed with #3908. I was also working a little on the @lerna/child-process package.

I think we could include types anyway and we just have to adapt paths in tsconfig.base.json.

@fahslaj
Copy link
Copy Markdown
Contributor Author

fahslaj commented Nov 21, 2023

@amorscher yep! This PR is the bare minimum to get it to be an internal package instead of external, but the next step will be to convert it fully to typescript.

@amorscher
Copy link
Copy Markdown
Contributor

@fahslaj ok so I could do the conversion when this PR is merged? I have done some of the work already in #3908 .

@fahslaj
Copy link
Copy Markdown
Contributor Author

fahslaj commented Nov 21, 2023

@amorscher yes that would be perfect.

@fahslaj fahslaj marked this pull request as ready for review November 22, 2023 01:03
@fahslaj fahslaj requested a review from JamesHenry November 22, 2023 01:18
@JamesHenry JamesHenry changed the title feat!: stop publishing child process feat!: stop publishing @lerna/child-process Nov 22, 2023
@JamesHenry JamesHenry merged commit 4f5edee into lerna:main Nov 22, 2023
@JamesHenry JamesHenry deleted the chore/stop-publishing-child-process branch November 22, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants