chore(child-process): convert to typescript#3908
Merged
fahslaj merged 9 commits intolerna:mainfrom Nov 28, 2023
Merged
Conversation
- diff command changed to benefit from types using import statements
10 tasks
fahslaj
reviewed
Nov 22, 2023
Contributor
There was a problem hiding this comment.
Let's wait on this until after #3909 is merged. (tagging @JamesHenry for visibility)
Contributor
Author
|
@fahslaj @JamesHenry just to clarify: I will port then the whole lib to typescript, replacing all js files with ts files. Not just adding a d.ts types file. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 11c1bba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 8 targets
Sent with 💌 from NxCloud. |
fahslaj
approved these changes
Nov 28, 2023
Contributor
|
Thanks @amorscher ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Convert all *.js files to typescript so we have full typechecking support for child-process lib. This enables to use import statements providing type awareness for all commands using lerna's child-process lib.
Motivation and Context
Make code more typesafe
How Has This Been Tested?
All tests still pass.
Types of changes
Checklist: