Skip to content

chore(e2e): update lockfile expectation to match yarn 4#3880

Merged
JamesHenry merged 1 commit intolerna:mainfrom
fahslaj:fix/yarn-4-e2e-fix
Oct 27, 2023
Merged

chore(e2e): update lockfile expectation to match yarn 4#3880
JamesHenry merged 1 commit intolerna:mainfrom
fahslaj:fix/yarn-4-e2e-fix

Conversation

@fahslaj
Copy link
Copy Markdown
Contributor

@fahslaj fahslaj commented Oct 26, 2023

Description

Updates the assertion in yarn-lockfiles.spec.ts to match what yarn 4 produces.

Motivation and Context

Our e2e tests run on the latest version of Yarn berry, which is now 4.0.0. This version of Yarn changed lockfiles slightly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review October 26, 2023 23:16
@fahslaj fahslaj requested a review from JamesHenry October 26, 2023 23:16
@fahslaj
Copy link
Copy Markdown
Contributor Author

fahslaj commented Oct 26, 2023

@JamesHenry this will fix the currently failing yarn berry e2e test

@JamesHenry JamesHenry merged commit 924f438 into lerna:main Oct 27, 2023
@JamesHenry JamesHenry deleted the fix/yarn-4-e2e-fix branch October 27, 2023 07:56
amorscher pushed a commit to amorscher/lerna that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants