Skip to content

Add "space-infix-ops" eslint rule#188

Merged
hzoo merged 1 commit intolerna:masterfrom
gigabo:space-infix-ops
Jun 7, 2016
Merged

Add "space-infix-ops" eslint rule#188
hzoo merged 1 commit intolerna:masterfrom
gigabo:space-infix-ops

Conversation

@gigabo
Copy link
Copy Markdown
Contributor

@gigabo gigabo commented Jun 7, 2016

http://eslint.org/docs/rules/space-infix-ops

Remarkably, this just passes. No violations. Nice work, Lerna!

http://eslint.org/docs/rules/space-infix-ops

Remarkably, this just passes.  No violations.  Nice work, Lerna!
@gigabo gigabo mentioned this pull request Jun 7, 2016
@gigabo
Copy link
Copy Markdown
Contributor Author

gigabo commented Jun 7, 2016

Suggested here.

gigabo added a commit to gigabo/lerna that referenced this pull request Jun 7, 2016
This is necessary for compatibility with lerna#188.
@hzoo hzoo merged commit c84a20b into lerna:master Jun 7, 2016
gigabo added a commit to gigabo/lerna that referenced this pull request Jun 9, 2016
This is necessary for compatibility with lerna#188.
gigabo added a commit to gigabo/lerna that referenced this pull request Jun 9, 2016
This is necessary for compatibility with lerna#188.
gigabo added a commit to gigabo/lerna that referenced this pull request Jun 17, 2016
This is necessary for compatibility with lerna#188.
gigabo added a commit to gigabo/lerna that referenced this pull request Jun 23, 2016
This is necessary for compatibility with lerna#188.
hzoo pushed a commit that referenced this pull request Jun 23, 2016
* Add `lerna import` command

Imports a package with git history from a foreign repository.

* Add tests for `lerna import`

* Fix linter violations

* Import "external" repo instead of "foreign" repo

* Add some commentary around mechanics of import

* Add some detail to the README entry for `import`

* Fix a README typo

* Add some whitespace around a concatenation operator

* Eliminate a "space-infix-ops" eslint rule violation

This is necessary for compatibility with #188.

* Handle `--yes` flag in import command

* Use directory name instead of package name during import

* Nicer error message for missing directory

Also add tests for error messages

* Don't import into pre-existing target directory

* Don't claim to use package name during import in README
@lock
Copy link
Copy Markdown

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants