Merged
Conversation
leonardbf
pushed a commit
that referenced
this pull request
May 15, 2019
* adding cluster admin option to osa create * adding direcctory read permissions to the aad app (#1) * adding cluster admin option to osa create * adding direcctory read permissions to the aad app * making active directory app always require directory permissions * infra node to 3 * adding new version of python sdk (#3) * adding cluster admin option to osa create * adding direcctory read permissions to the aad app * making app always require directory permissions * clean + infra node to 3 * fixing typo * using new version of acs python sdk * updating history.rst * Change type from scope to role * apply review * pep fix * fix merge conflict * update history and help * update recorded aks tests * Revert "update recorded aks tests" This reverts commit 8643736. * change api version for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the Azure NetApp Files CLI was an extension only.
R4 standard of RP for GA
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.