Add TCA & Vignetting for Meike 85mm f/1.8#2714
Merged
tuxfanx merged 3 commits intolensfun:masterfrom Mar 5, 2026
Merged
Conversation
Note that the Exif Data shows "SKY85mm" and includes the firmware date
kmilos
reviewed
Feb 20, 2026
data/db/misc.xml
Outdated
| <!-- Note: the LensModel string is actually "SKY85mm f/1.8 DCM "$FIRMWARE_DATE so | ||
| the latest EF name is "SKY85mm f/1.8 DCM Mar 7", but that is terrile to match | ||
| so we list this as the actual lens name --> | ||
| <model>Meike 85mm f/1.8 DCM</model> |
Contributor
There was a problem hiding this comment.
Please remove the "DCM" if this is to work across mounts, that designation is Canon EF specific?
Also, looking at https://radojuva.com/en/2023/10/meike-85mm-1-8-auto-focus-lens-ff-stm-e-x-z-rf-review/ there seem to be at least 3 versions of this lens (4 if we count gen II), so I'm really not sure about adding it without checking out more samples for more versions and more mounts.
Contributor
Author
There was a problem hiding this comment.
Unfortunately Cloudflare isn't letting me access that link, can you copy the relevant bits here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the Exif Data shows "SKY85mm" and includes the firmware date. As per #2712 this will be a manual selection.
Related: Exiv2/exiv2#3496