Skip to content

Add Lens ID for Meike 85mm f/1.8 (DCM)#3496

Open
byteit101 wants to merge 1 commit intoExiv2:mainfrom
byteit101:meike85
Open

Add Lens ID for Meike 85mm f/1.8 (DCM)#3496
byteit101 wants to merge 1 commit intoExiv2:mainfrom
byteit101:meike85

Conversation

@byteit101
Copy link
Copy Markdown
Contributor

@byteit101 byteit101 commented Feb 17, 2026

Oddly, LensModel is "SKY85mm f/1.8 DCM" + the firmware date. I wasn't sure how to fix that or if it should be fixed, hence why this is a draft.

Output with this change:

before_update.CR2  Exif.CanonCs.LensType                        Short       1  Meike 85mm f/1.8 DCM
before_update.CR2  Exif.CanonCs.Lens                            Short       3  85.0 mm
before_update.CR2  Exif.Canon.LensModel                         Ascii      74  SKY85mm f/1.8 DCM Mar  7
before_update.CR2  Exif.CanonLe.LensSerialNumber                Byte        5  0000d51700
before_update.CR2  Exif.Photo.LensSpecification                 Rational    4  85mm
before_update.CR2  Exif.Photo.LensModel                         Ascii      25  SKY85mm f/1.8 DCM Mar  7
before_update.CR2  Exif.Photo.LensSerialNumber                  Ascii      11  0000d51700


after_update.CR2  Exif.CanonCs.LensType                        Short       1  Meike 85mm f/1.8 DCM
after_update.CR2  Exif.CanonCs.Lens                            Short       3  85.0 mm
after_update.CR2  Exif.Canon.LensModel                         Ascii      74  SKY85mm f/1.8 DCM Jun  1
after_update.CR2  Exif.CanonLe.LensSerialNumber                Byte        5  0000d51700
after_update.CR2  Exif.Photo.LensSpecification                 Rational    4  85mm
after_update.CR2  Exif.Photo.LensModel                         Ascii      25  SKY85mm f/1.8 DCM Jun  1
after_update.CR2  Exif.Photo.LensSerialNumber                  Ascii      11  0000d51700

@byteit101
Add Lens ID for Meike 85mm f/1.8 (DCM)
c780b49 
Note that LensModel is "SKY85mm f/1.8 DCM" + the firmware date
@kmilos
Copy link
Copy Markdown
Collaborator

kmilos commented Feb 18, 2026 •
edited
Loading

I wasn't sure how to fix that or if it should be fixed

You can't, this is an "Ascii" tag, so it's literally like that in the metadata written by the lens vendor (or Canon). You can verify the output of exiv2 -Pkyvt ("v" is for literal value, "t" is for exiv2 translated/interpreted one).

Btw, any other reference for this lens? It's not in exiftool...

I also can't find it at https://meikeglobal.com/ so I'd be wary of adding this particular one, especially as there is the exiv2.ini workaround available...

@kmilos kmilos added the lens Issue related to lens detection label Feb 18, 2026
@byteit101 byteit101 marked this pull request as ready for review February 19, 2026 22:35
@byteit101 byteit101 mentioned this pull request Feb 19, 2026
Merged
@byteit101
Copy link
Copy Markdown
Contributor Author

byteit101 commented Feb 19, 2026

Btw, any other reference for this lens? It's not in exiftool...

I also can't find it at https://meikeglobal.com/ so I'd be wary of adding this particular one, especially as there is the exiv2.ini workaround available...

Frustratingly they just released mark II, and have nearly scrubbed gen I from most places on their website.

I'm currently about to contribute a lensfun profile, and working on the exiftool changes as well

@byteit101 byteit101 mentioned this pull request Feb 19, 2026
Closed
@kmilos
Copy link
Copy Markdown
Collaborator

kmilos commented Feb 20, 2026 •
edited
Loading

The firmware update page has it under 85mm F1.8: https://meikeglobal.com/pages/firmware-upgrade

If we add it as "Meike 85mm f/1.8 DCM" for Canon EF, will lensfun still match it to "Meike 85mm f/1.8" across all mounts?

@kmilos
Copy link
Copy Markdown
Collaborator

kmilos commented Feb 20, 2026

Also, looking at https://radojuva.com/en/2023/10/meike-85mm-1-8-auto-focus-lens-ff-stm-e-x-z-rf-review/ there seem to be at least 3 versions of this lens (4 if we count gen II), so I'm really not sure about adding it without checking out more samples for more versions and more mounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lens Issue related to lens detection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@byteit101 @kmilos