Fix serialize type deprecation warning on Rails 7.1+#113
Merged
ledermann merged 5 commits intoledermann:masterfrom Sep 22, 2023
mikker:rails-7-1
Merged
Fix serialize type deprecation warning on Rails 7.1+#113ledermann merged 5 commits intoledermann:masterfrom mikker:rails-7-1
ledermann merged 5 commits intoledermann:masterfrom
mikker:rails-7-1
Conversation
Contributor
Author
|
Not sure what the best version number to compare against is but currently if ActiveRecord.version >= "7.1.0.beta1"On final release, maybe we could change it to just "7.1.0" which reads a bit better IMO. Not sure. |
ledermann
reviewed
Sep 22, 2023
Owner
ledermann
left a comment
There was a problem hiding this comment.
Thanks, LGTM. One minor thing: Can you remove the unrelated formatting changes, please?
This reverts commit 6bbc2ff.
Contributor
Author
|
Of course! Forgot to turn off Rubyfmt in that last commit 🙄 |
Owner
|
Great, thanks! |
Contributor
Author
|
Thank you for the quick response 🤝 |
lluis
pushed a commit
to visrez/rails-settings
that referenced
this pull request
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to Rails 7.1 is giving me this warning when my app boots:
This fixes it.