[Merged by Bors] - chore: clean up uses of Pi.smul_apply#9970
Closed
mattrobball wants to merge 13 commits intomasterfrom
Closed
[Merged by Bors] - chore: clean up uses of Pi.smul_apply#9970mattrobball wants to merge 13 commits intomasterfrom
Pi.smul_apply#9970mattrobball wants to merge 13 commits intomasterfrom
Conversation
|
This PR/issue depends on: |
Contributor
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
After #9949, `Pi.smul_apply` can be used in `simp` again. This PR cleans up some workarounds.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Pi.smul_applyPi.smul_apply
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
After #9949, `Pi.smul_apply` can be used in `simp` again. This PR cleans up some workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #9949,
Pi.smul_applycan be used insimpagain. This PR cleans up some workarounds.toFunandsmulinAlgebra.id#9949