Skip to content

[Merged by Bors] - fix: adaptations for nightly-2024-01-24 (leanprover/lean4#3060)#9943

Closed
eric-wieser wants to merge 2 commits intobump/v4.6.0from
lean-pr-testing-3060
Closed

[Merged by Bors] - fix: adaptations for nightly-2024-01-24 (leanprover/lean4#3060)#9943
eric-wieser wants to merge 2 commits intobump/v4.6.0from
lean-pr-testing-3060

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Jan 23, 2024

leanprover/lean4#3060 exposed the latent leanprover-community/quote4#30 (by propagating it from if let and match to let). The workaround is thankfully trivial.


Open in Gitpod

I haven't adjusted the lean-toolchain yet.

@eric-wieser eric-wieser added the lean4-change-in-behaviour Describes a known change in behaviour. No implication that it "needs fixing". label Jan 23, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jan 24, 2024

Please merge once you've updated the lean-toolchain, and #9960 is in.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 24, 2024

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 24, 2024
@eric-wieser
Copy link
Copy Markdown
Member Author

eric-wieser commented Jan 25, 2024

It looks like there are other changes in this nightly that require a change to Std first.

@nomeata
Copy link
Copy Markdown
Collaborator

nomeata commented Jan 25, 2024

@eric-wieser, I think this is good to go.

@eric-wieser eric-wieser changed the title fix: fixes for lean4#3060 fix: adaptations for nightly-2024-01-24 (leanprover/lean4#3060) Jan 25, 2024
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 25, 2024
leanprover/lean4#3060 exposed the latent leanprover-community/quote4#30 (by propagating it from `if let` and `match` to `let`). The workaround is thankfully trivial.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 25, 2024

Pull request successfully merged into bump/v4.6.0.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: adaptations for nightly-2024-01-24 (leanprover/lean4#3060) [Merged by Bors] - fix: adaptations for nightly-2024-01-24 (leanprover/lean4#3060) Jan 25, 2024
@mathlib-bors mathlib-bors bot closed this Jan 25, 2024
@mathlib-bors mathlib-bors bot deleted the lean-pr-testing-3060 branch January 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). lean4-change-in-behaviour Describes a known change in behaviour. No implication that it "needs fixing". ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants