[Merged by Bors] - refactor(*): abbreviation for non-dependent FunLike#9833
Closed
Vierkantor wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - refactor(*): abbreviation for non-dependent FunLike#9833Vierkantor wants to merge 7 commits intomasterfrom
FunLike#9833Vierkantor wants to merge 7 commits intomasterfrom
Conversation
This follows up from #9785, which renamed `FunLike` to `DFunLike`, by introducing a new abbreviation `FunLike F α β := DFunLike F α (fun _ => β)`, to make the non-dependent use of `FunLike` easier.
This was referenced Jan 18, 2024
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
This follows up from #9785, which renamed `FunLike` to `DFunLike`, by introducing a new abbreviation `FunLike F α β := DFunLike F α (fun _ => β)`, to make the non-dependent use of `FunLike` easier. I searched for the pattern `DFunLike.*fun` and `DFunLike.*λ` in all files to replace expressions of the form `DFunLike F α (fun _ => β)` with `FunLike F α β`. I did this everywhere except for `extends` clauses for two reasons: it would conflict with #8386, and more importantly `extends` must directly refer to a structure with no unfolding of `def`s or `abbrev`s.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
FunLikeFunLike
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up from #9785, which renamed
FunLiketoDFunLike, by introducing a new abbreviationFunLike F α β := DFunLike F α (fun _ => β), to make the non-dependent use ofFunLikeeasier.I searched for the pattern
DFunLike.*funandDFunLike.*λin all files to replace expressions of the formDFunLike F α (fun _ => β)withFunLike F α β. I did this everywhere except forextendsclauses for two reasons: it would conflict with #8386, and more importantlyextendsmust directly refer to a structure with no unfolding ofdefs orabbrevs.