Skip to content

[Merged by Bors] - feat: case-specific equivalences for IsROrC#9782

Closed
j-loreaux wants to merge 5 commits intomasterfrom
j-loreaux/IsROrC-case-equivs
Closed

[Merged by Bors] - feat: case-specific equivalences for IsROrC#9782
j-loreaux wants to merge 5 commits intomasterfrom
j-loreaux/IsROrC-case-equivs

Conversation

@j-loreaux
Copy link
Copy Markdown
Contributor

This adds ring isomorphisms and linear isometry equivalences between 𝕜 satisfying IsROrC 𝕜 and or depending on whether I = 0 or im I = 1. Of course, the design of IsROrC is meant to eliminate the need for such things most of the time, but these are helpful in the rare case one actually does need to split into the two cases in the middle of a proof.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review t-analysis Analysis (normed *, calculus) labels Jan 16, 2024
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I commented here, I think you don't actually need this for #9788, but this is nice to have anyways.

Thanks!

bors d+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 16, 2024
@ADedecker
Copy link
Copy Markdown
Member

bors r-

I messed up

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 16, 2024

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 16, 2024

Canceled.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 16, 2024
@ADedecker ADedecker removed the ready-to-merge This PR has been sent to bors. label Jan 16, 2024
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@j-loreaux
Copy link
Copy Markdown
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 23, 2024
This adds ring isomorphisms and linear isometry equivalences between `𝕜` satisfying `IsROrC 𝕜` and `ℝ` or `ℂ` depending on whether `I = 0` or `im I = 1`. Of course, the design of `IsROrC` is meant to eliminate the need for such things most of the time, but these are helpful in the rare case one actually does need to split into the two cases in the middle of a proof.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: case-specific equivalences for IsROrC [Merged by Bors] - feat: case-specific equivalences for IsROrC Jan 23, 2024
@mathlib-bors mathlib-bors bot closed this Jan 23, 2024
@mathlib-bors mathlib-bors bot deleted the j-loreaux/IsROrC-case-equivs branch January 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants