Skip to content

[Merged by Bors] - doc(Geometry/Manifold/LieGroup): extend and clean up docstrings#9766

Closed
grunweg wants to merge 7 commits intomasterfrom
MR-Liegroup-cleanup
Closed

[Merged by Bors] - doc(Geometry/Manifold/LieGroup): extend and clean up docstrings#9766
grunweg wants to merge 7 commits intomasterfrom
MR-Liegroup-cleanup

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 15, 2024

  • tweak section names; add comments explaining what's in them
  • add two lemma docstrings
  • revamp the module docstring to mention all results
  • in the module docstring, separate main definitions and results

Open in Gitpod

@j-loreaux
Copy link
Copy Markdown
Contributor

j-loreaux commented Jan 15, 2024

@grunweg yes, please remove the autoImplicit commit so that these PRs can just be handled separately, especially since neither one has a depends on line in the PR description.

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jan 15, 2024
@grunweg grunweg force-pushed the MR-Liegroup-cleanup branch from b031111 to ff339e4 Compare January 15, 2024 22:00
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 15, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jan 15, 2024
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jan 15, 2024
@j-loreaux
Copy link
Copy Markdown
Contributor

Please also update the PR description (and title if relevant)

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 16, 2024

Thanks for the fast review! I just incorporated all comments and also pushed two more commits tweaking the docs further.
awaiting-review

@github-actions github-actions bot added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jan 16, 2024
@grunweg grunweg changed the title chore+doc(Geometry/Manifold/LieGroup): docstrings and minor clean-up doc(Geometry/Manifold/LieGroup): extend and clean up docstrings Jan 16, 2024
@j-loreaux
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
- tweak section names; add comments explaining what's in them
- add two lemma docstrings
- revamp the module docstring to mention all results
- in the module docstring, separate main definitions and results
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(Geometry/Manifold/LieGroup): extend and clean up docstrings [Merged by Bors] - doc(Geometry/Manifold/LieGroup): extend and clean up docstrings Jan 16, 2024
@mathlib-bors mathlib-bors bot closed this Jan 16, 2024
@mathlib-bors mathlib-bors bot deleted the MR-Liegroup-cleanup branch January 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants