[Merged by Bors] - refactor: Clean up posPart#9740
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - refactor: Clean up posPart#9740YaelDillies wants to merge 2 commits intomasterfrom
posPart#9740YaelDillies wants to merge 2 commits intomasterfrom
Conversation
This changes the typeclass notation approach with plain functions. Followup to #9553
21 tasks
Contributor
|
Pull request successfully merged into master. Build succeeded: |
posPartposPart
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
`Algebra.GroupPower.Lemmas` used to be a big bag of lemmas that made it there on the criterion that they needed "more imports". This was completely untrue, as all lemmas could be moved to earlier files in PRs: - #9440 - #9442 - #9443 - #9455 - #9456 - #9457 - #9459 - #9461 - #9463 - #9466 - #9501 - #9502 - #9503 - #9505 - #9551 - #9553 - #9720 - #9739 - #9740 - #9805 - #9806 - and this one There are several reasons for this: * Necessary lemmas have been moved to earlier files since lemmas were dumped in `Algebra.GroupPower.Lemmas` * In the Lean 3 → Lean 4 transition, Std acquired basic `Int` and `Nat` lemmas which let us shortcircuit the part of the algebraic order hierarchy on which the corresponding general lemmas rest * Some proofs were overpowered * Some earlier files were tangled and I have untangled them This PR finishes the job by moving the last few lemmas out of `Algebra.GroupPower.Lemmas`, which is therefore deleted.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
`Algebra.GroupPower.Lemmas` used to be a big bag of lemmas that made it there on the criterion that they needed "more imports". This was completely untrue, as all lemmas could be moved to earlier files in PRs: - #9440 - #9442 - #9443 - #9455 - #9456 - #9457 - #9459 - #9461 - #9463 - #9466 - #9501 - #9502 - #9503 - #9505 - #9551 - #9553 - #9720 - #9739 - #9740 - #9805 - #9806 - and this one There are several reasons for this: * Necessary lemmas have been moved to earlier files since lemmas were dumped in `Algebra.GroupPower.Lemmas` * In the Lean 3 → Lean 4 transition, Std acquired basic `Int` and `Nat` lemmas which let us shortcircuit the part of the algebraic order hierarchy on which the corresponding general lemmas rest * Some proofs were overpowered * Some earlier files were tangled and I have untangled them This PR finishes the job by moving the last few lemmas out of `Algebra.GroupPower.Lemmas`, which is therefore deleted.
2 tasks
YaelDillies
added a commit
that referenced
this pull request
Feb 18, 2024
These two notation classes should have been removed in #9740
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 18, 2024
These two notation classes should have been removed in #9740
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 18, 2024
These two notation classes should have been removed in #9740
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 19, 2024
These two notation classes should have been removed in #9740
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
These two notation classes should have been removed in #9740
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
These two notation classes should have been removed in #9740
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
These two notation classes should have been removed in #9740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the typeclass notation approach with plain functions.
Followup to #9553. Part of #9411