[Merged by Bors] - feat: Refactor ConnectedComponent#971
Closed
[Merged by Bors] - feat: Refactor ConnectedComponent#971
Conversation
… in order to sync with PR 17665 on mathlib3.
1 task
YaelDillies
reviewed
Dec 13, 2022
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
…com/leanprover-community/mathlib4 into bottine/Quiver/edge_reversal_refactor
YaelDillies
approved these changes
Dec 13, 2022
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Let's wait for the mathlib PR to get in.
Contributor
Author
|
I'm currently changing the mathlib3 PR according to Yael's suggestion. Will update this one to synchronize when the mathlib3 one gets approved. |
Contributor
Author
|
NB: I believe the troubles with universes that forced the mathlib3 definition of |
Contributor
|
bors d+ |
|
✌️ bottine can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 17, 2022
… in order to sync with PR 17665 on mathlib3. See leanprover-community/mathlib3#17665 Co-authored-by: Rémi Bottinelli <bottine@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in order to sync with PR 17665 on mathlib3.
See leanprover-community/mathlib3#17665