[Merged by Bors] - chore(Topology/PartialHomeomorph): minor clean-up#9633
Closed
[Merged by Bors] - chore(Topology/PartialHomeomorph): minor clean-up#9633
Conversation
And avoid some variable binder update.
2 tasks
sgouezel
reviewed
Jan 16, 2024
Contributor
Author
|
awaiting-review |
j-loreaux
reviewed
Jan 19, 2024
Contributor
j-loreaux
left a comment
There was a problem hiding this comment.
Thanks! Just minor quibbles.
After fixing the issues below, please wait for CI to finish before merging.
bors d+
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Green (except for lean4checker, which should pass). Thanks for the review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
- group related results into sections - move one section up, to a more logical place
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit; the third commit is purely code motion. (Using the colorMoved option makes this obvious. Unfortunately, that's not available in the Github UI.)