Skip to content

[Merged by Bors] - feat: Generalize corollaries of rank-nullity theorem.#9626

Closed
erdOne wants to merge 27 commits intomasterfrom
erd1/rankNullityGeneralization
Closed

[Merged by Bors] - feat: Generalize corollaries of rank-nullity theorem.#9626
erdOne wants to merge 27 commits intomasterfrom
erd1/rankNullityGeneralization

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Jan 10, 2024

Added a class HasRankNullity consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file LinearAlgebra.Dimension.RankNullity.


Open in Gitpod

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@erdOne erdOne added awaiting-review t-algebra Algebra (groups, rings, fields, etc) labels Jan 10, 2024
@riccardobrasca riccardobrasca self-assigned this Jan 10, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 19, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

@erdOne are you still interested in working on this PR? Or is it obsolete now?

@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Feb 23, 2024

I'm busy until mid-March. I think I'll come back to this after that. Feel free to adopt if this is needed elsewhere.

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 26, 2024
@erdOne erdOne requested a review from riccardobrasca April 2, 2024 12:59
@riccardobrasca
Copy link
Copy Markdown
Member

Can you add a description of the PR?

Also, is it possible to split it? Correct me if I am wrong, but I have the impression you both generalize/move current results and add a new class. Maybe these two things are intertwined and difficult to separate, so don't worry if it is too much work to do it.

@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Apr 3, 2024
@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Apr 4, 2024
@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Apr 5, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

Build failed (retrying...):

  • Build

@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Apr 5, 2024

bors r-
Can you merge master and fix the build before sending it back to bors?
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

Canceled.

Comment on lines +214 to +218
lemma exists_set_linearIndependent_of_lt_rank {n : Cardinal} (hn : n < Module.rank R M) :
∃ s : Set M, #s = n ∧ LinearIndependent R ((↑) : s → M) := by
obtain ⟨⟨s, hs⟩, hs'⟩ := exists_lt_of_lt_ciSup' (hn.trans_eq (Module.rank_def R M))
obtain ⟨t, ht, ht'⟩ := le_mk_iff_exists_subset.mp hs'.le
exact ⟨t, ht', .mono ht hs⟩
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the condition of this result to [Semiring R] [AddCommMonoid M] [Module R M]? Same as the following exists_finset_linearIndependent_of_le_rank.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK if you do it in later PR; I only need to use the ring version.

@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Apr 12, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 12, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Generalize corollaries of rank-nullity theorem. [Merged by Bors] - feat: Generalize corollaries of rank-nullity theorem. Apr 12, 2024
@mathlib-bors mathlib-bors bot closed this Apr 12, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/rankNullityGeneralization branch April 12, 2024 16:18
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
Added a class `HasRankNullity` consisting of the rings that satisfy the rank-nullity theorem.
Generalized the corollaries of the rank-nullity theorem from division rings to rings satisfying the class,
and moved them into a new file `LinearAlgebra.Dimension.RankNullity`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants