[Merged by Bors] - hack: to_additive copies more attributes#954
Closed
fpvandoorn wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - hack: to_additive copies more attributes#954fpvandoorn wants to merge 7 commits intomasterfrom
fpvandoorn wants to merge 7 commits intomasterfrom
Conversation
Contributor
|
I think you're underselling this solution, and don't mind at all if you remove bors d+ |
|
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
add a "@[todo]" that this should be changed - "hacky" in the declaration name is not something I would search for if I wanted to find things to fix. |
Member
Author
|
bors merge I keep the hacky in the name for now (to hopefully ensure that if someone uses it, they at least read the docstring and test whether it works). I also added a todo in the docstring. |
bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
* `to_additive` now copies `ext`, `coe`, `refl`, `symm`, `trans` * Implemented in a hacky way * This could be used until a proper solution is available.
|
Pull request successfully merged into master. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_additivenow copiesext,coe,refl,symm,trans