Skip to content

[Merged by Bors] - feat: deprecate div_le_div_of_le_of_nonneg#9399

Closed
Parcly-Taxel wants to merge 2 commits intomasterfrom
div_le_div_of_le_dedupe
Closed

[Merged by Bors] - feat: deprecate div_le_div_of_le_of_nonneg#9399
Parcly-Taxel wants to merge 2 commits intomasterfrom
div_le_div_of_le_dedupe

Conversation

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

@Parcly-Taxel Parcly-Taxel commented Jan 2, 2024

This was noticed in the discussion around #9393.


Open in Gitpod

@Parcly-Taxel Parcly-Taxel added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 2, 2024
@Parcly-Taxel Parcly-Taxel requested a review from urkud January 4, 2024 03:29
@jcommelin
Copy link
Copy Markdown
Member

bors d=yaeldillies

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 4, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jan 4, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor

Actually, @newell has a refactor touching these files. Are you happy with this PR going through, Newell?

@newell newell closed this Jan 4, 2024
@newell newell reopened this Jan 4, 2024
@newell
Copy link
Copy Markdown
Collaborator

newell commented Jan 4, 2024

Sorry about closing the PR and reopening it, my mouse had other ideas!

@YaelDillies
Copy link
Copy Markdown
Contributor

Okay, let's merge this for now.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 4, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@YaelDillies
Copy link
Copy Markdown
Contributor

Sorry, meant

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 4, 2024
This was noticed in the discussion around #9393.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: deprecate div_le_div_of_le_of_nonneg [Merged by Bors] - feat: deprecate div_le_div_of_le_of_nonneg Jan 4, 2024
@mathlib-bors mathlib-bors bot closed this Jan 4, 2024
@mathlib-bors mathlib-bors bot deleted the div_le_div_of_le_dedupe branch January 4, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants