[Merged by Bors] - feat port: Algebra.Order.LatticeGroup#934
Closed
ChrisHughes24 wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - feat port: Algebra.Order.LatticeGroup#934ChrisHughes24 wants to merge 9 commits intomasterfrom
ChrisHughes24 wants to merge 9 commits intomasterfrom
Conversation
Collaborator
|
Another possibility would be to drop the multiplicative form and convert all the results to additive form. Applications of this theory are usually to partially ordered vector spaces, and the multiplicative form is rarely used. |
Contributor
|
I suspect all remaining issues are #1149. I don't know if we want to work around it by squeezing all the affected |
Collaborator
Collaborator
|
@ChrisHughes24 It builds now. |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
10b4e499f43088dd3bb7b5796184ad5216648ab1 There are a lot of failures of `to_additive` in this file. Probably `to_additive` needs to be improved Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
10b4e499f43088dd3bb7b5796184ad5216648ab1 There are a lot of failures of `to_additive` in this file. Probably `to_additive` needs to be improved Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10b4e499f43088dd3bb7b5796184ad5216648ab1
There are a lot of failures of
to_additivein this file. Probablyto_additiveneeds to be improved