[Merged by Bors] - feat(Analysis/SpecialFunctions/Complex/Arg): add definition for slit plane and API, and use it#9116
Closed
MichaelStollBayreuth wants to merge 11 commits intomasterfrom
Closed
[Merged by Bors] - feat(Analysis/SpecialFunctions/Complex/Arg): add definition for slit plane and API, and use it#9116MichaelStollBayreuth wants to merge 11 commits intomasterfrom
MichaelStollBayreuth wants to merge 11 commits intomasterfrom
Conversation
Member
|
I generalized the "star shaped" lemma and moved it to a new file. I also dropped in a lemma I wrote a few days ago but forgot to PR. Also, I added some lemmas and golfed proofs using |
Contributor
Author
|
OK, nice. There is still a broken proof, though. |
Member
|
LGTM but I contributed too much to merge it myself. Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by urkud. |
sgouezel
reviewed
Dec 22, 2023
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2023
…plane and API, and use it (#9116) In preparation of future PRs dealing with estimates of the complex logarithm and its Taylor series, this introduces `Complex.slitPlane` for the set of complex numbers not on the closed negative real axis (in `Analysis.SpecialFunctions.Complex.Arg`), adds a bunch of API lemmas, and replaces hypotheses of the form `0 < x.re ∨ x.im ≠ 0` by `x ∈ slitPlane` in several other files. (We do not introduce a new file for that to avoid circular imports with `Analysis.SpecialFunctions.Complex.Arg`.) Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of future PRs dealing with estimates of the complex logarithm and its Taylor series, this introduces
Complex.slitPlanefor the set of complex numbers not on the closed negative real axis (inAnalysis.SpecialFunctions.Complex.Arg), adds a bunch of API lemmas, and replaces hypotheses of the form0 < x.re ∨ x.im ≠ 0byx ∈ slitPlanein several other files.(We do not introduce a new file for that to avoid circular imports with
Analysis.SpecialFunctions.Complex.Arg.)