[Merged by Bors] - fix: update comment and code referring to old split_ifs bug#908
Closed
[Merged by Bors] - fix: update comment and code referring to old split_ifs bug#908
Conversation
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
Now that #761 has landed, we can use `split_ifs` in the proof of `setValue`. The proof is still not as nice as it could be, because we don't have `cc` yet.
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
Followup to #908. Apparently `<;>` (in addition to plain `;`) has higher precedence than `try`. Adding parentheses restores the expected behavior. This isn't the first time we've been tripped up by unexpected precedence in the sequencing operators. See e.g. #370 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #761 has landed, we can use
split_ifsin the proof ofsetValue.The proof is still not as nice as it could be, because we don't have
ccyet.