[Merged by Bors] - chore: make Complex.ext only a local ext lemma#9010
Closed
[Merged by Bors] - chore: make Complex.ext only a local ext lemma#9010
Complex.ext only a local ext lemma#9010Conversation
Contributor
|
Looks good to me. Thanks for following up on this -- this ext lemma was annoying me too today. bors d+ |
Contributor
|
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
In accordance with this [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Complex.2Eext/near/393560116), this remove `Complex.ext` from the global `ext` attribute list and only enables it locally in certain files.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Complex.ext only a local ext lemmaComplex.ext only a local ext lemma
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
In accordance with this [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Complex.2Eext/near/393560116), this remove `Complex.ext` from the global `ext` attribute list and only enables it locally in certain files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with this Zulip thread, this remove
Complex.extfrom the globalextattribute list and only enables it locally in certain files.I only activated
Complex.extas a local attribute if one of the following conditions were met:Complex.extmultiple times as anextcall and the file was aboutℂ.extcall was using multiple lemmas in addition toComplex.ext.Otherwise, I just substituted
apply Complex.ext