[Merged by Bors] - chore: rename LocalHomeomorph to PartialHomeomorph#8982
Closed
[Merged by Bors] - chore: rename LocalHomeomorph to PartialHomeomorph#8982
Conversation
Done automatically (needed to re-add namespaces in the aligns, a bug).
This exposes another bug in renaming: Homeomorph.toLocalHomeomorph gets renamed to _root_.Homeomorph.toPartialHomeomorph at all call sites, which doesn't compile. It seems the rename handler is not aware of namespaces yet.
I'm not sure about the other instances; most of them are actual math local homeomorphisms. I haven't audited them all carefully.
alreadydone
approved these changes
Dec 11, 2023
Contributor
alreadydone
left a comment
There was a problem hiding this comment.
Thanks! LGTM
Renaming LocalEquiv to PartialEquiv also sounds good to me; fortunately the name was not taken by PEquiv, the same concept with a different design.
Contributor
Author
|
Wow, you're fast :-) Thanks for the fast approval! |
Member
|
Unfortunately it also got a merge conflict quickly... |
Member
|
Thanks! This was on my "should be done eventually"-list for a while. Let's try to merge this quickly. Please merge master, and merge with bors d+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Builds and tests pass, so... bors r+ |
Contributor
Author
|
bors r+ |
1 task
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
`LocalHomeomorph` evokes a "local homeomorphism": this is *not* what this means. Instead, this is a homeomorphism on an open set of the domain (extended to the whole space, by the junk value pattern). Hence, partial homeomorphism is more appropriate, and avoids confusion with `IsLocallyHomeomorph`. A future PR will rename `LocalEquiv` to `PartialEquiv`. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20around.20local.20homeomorphisms/near/407090631)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
`LocalHomeomorph` evokes a "local homeomorphism": this is *not* what this means. Instead, this is a homeomorphism on an open set of the domain (extended to the whole space, by the junk value pattern). Hence, partial homeomorphism is more appropriate, and avoids confusion with `IsLocallyHomeomorph`. A future PR will rename `LocalEquiv` to `PartialEquiv`. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20around.20local.20homeomorphisms/near/407090631)
This was referenced Dec 23, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Follow-up to #8982; a few lemma names were still wrong. Co-authored-by: Winston Yin <winstonyin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalHomeomorphevokes a "local homeomorphism": this is not what this means.Instead, this is a homeomorphism on an open set of the domain (extended to the whole space, by the junk value pattern). Hence, partial homeomorphism is more appropriate, and avoids confusion with
IsLocallyHomeomorph.A future PR will rename
LocalEquivtoPartialEquiv.Zulip discussion
Best reviewed commit by commit: each commit message clearly states what's in it.