[Merged by Bors] - chore: Sink Algebra.Support down the import tree#8919
Closed
YaelDillies wants to merge 11 commits intomasterfrom
Closed
[Merged by Bors] - chore: Sink Algebra.Support down the import tree#8919YaelDillies wants to merge 11 commits intomasterfrom
Algebra.Support down the import tree#8919YaelDillies wants to merge 11 commits intomasterfrom
Conversation
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only one import could not easily be reversed, namely the one to `Data.Set.Finite`, so I created a new file instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
eric-wieser
reviewed
Dec 9, 2023
| @[simp] | ||
| theorem support_mul [MulZeroClass R] [NoZeroDivisors R] (f g : α → R) : | ||
| (support fun x => f x * g x) = support f ∩ support g := | ||
| support_smul f g |
Member
There was a problem hiding this comment.
It's a shame this proof no longer works; are there many others like this, or is it the only one?
Contributor
Author
There was a problem hiding this comment.
It's the only one.
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only two import could not easily be reversed, namely the ones to `Data.Set.Finite` and `Order.ConditionallyCompleteLattice.Basic`, so I created two new files instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Algebra.Support down the import treeAlgebra.Support down the import tree
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only two import could not easily be reversed, namely the ones to `Data.Set.Finite` and `Order.ConditionallyCompleteLattice.Basic`, so I created two new files instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function.supportis a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects asupportlemma can be written about.This PR reverses the dependencies between those objects and
Function.support, so that the latter can become a much more lightweight import.Only two import could not easily be reversed, namely the ones to
Data.Set.FiniteandOrder.ConditionallyCompleteLattice.Basic, so I created two new files instead.I credit:
function.mul_supportmathlib3#6791finprod_mem_finset_of_productmathlib3#7439