[Merged by Bors] - chore: tidy various files#8880
Closed
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore: tidy various files#8880Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Conversation
Contributor
Ruben-VandeVelde
commented
Dec 7, 2023
sgouezel
reviewed
Dec 8, 2023
| _ = ∑ i, (f i) • (basisModTorsion K i) := by | ||
| simp_rw [fundSystem, QuotientGroup.out_eq', ofMul_toMul] | ||
| Additive.ofMul ↑x | ||
| _ = ∑ i, (f i) • Additive.ofMul ↑(fundSystem K i) := by |
Contributor
There was a problem hiding this comment.
Suggested change
| _ = ∑ i, (f i) • Additive.ofMul ↑(fundSystem K i) := by | |
| = ∑ i, (f i) • Additive.ofMul ↑(fundSystem K i) := by |
I find it odd to put an underscore with no meaning whatsoever.
Contributor
Author
There was a problem hiding this comment.
This syntax was added for exactly this case, so I'd rather opt to keep it
Contributor
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.