[Merged by Bors] - chore: rename {LocalHomeomorph,ChartedSpace}.continuous_{to,inv}Fun fields to continuousOn_{to,inv}Fun#8848
Closed
[Merged by Bors] - chore: rename {LocalHomeomorph,ChartedSpace}.continuous_{to,inv}Fun fields to continuousOn_{to,inv}Fun#8848
Conversation
…{to,inv}Fun.
They have type ContinuousOn ..., hence should be named accordingly.
…{to,inv}Fun in comments either.
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…ields to continuousOn_{to,inv}Fun (#8848)
They have type ContinuousOn ..., hence should be named accordingly. Suggested by @fpvandoorn in #8736.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…ields to continuousOn_{to,inv}Fun (#8848)
They have type ContinuousOn ..., hence should be named accordingly. Suggested by @fpvandoorn in #8736.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They have type ContinuousOn ..., hence should be named accordingly. Suggested by @fpvandoorn in #8736.
None of these fields is ever used in a doc comment. Best reviewed commit-by-commit; the first was created merely by renaming.
I can generate the
leaffoutput for this PR if that's helpful; let me know.Created using the new rename handler. @digama0 This worked like a charm; thanks for creating this!