[Merged by Bors] - chore: Replace (· op ·) a by (a op ·)#8843
[Merged by Bors] - chore: Replace (· op ·) a by (a op ·)#8843YaelDillies wants to merge 16 commits intomasterfrom
(· op ·) a by (a op ·)#8843Conversation
I used the regex `\(\(· (.) ·\) (.)\)`, replacing with `($2 $1 ·)`.
|
I don't think we want to do this; we're still holding out for an upstream fix that makes cc @digama0, who had thoughts on a similar PR. |
|
Surely if we can make And this is an improvement in the short term too, as can be evidenced by the number of |
|
Replacing |
|
I guess my point is that this PR is both a proof convenience and readability improvement in a way that other solutions will converge to if they improve both proof convenience and readability. |
The implementation leanprover/lean4#2267 does general eta reduction, there is nothing specific to binary operators in it. I support this PR, it is a mathportism (I really wanted to do this directly in mathport but there were some complications IIRC). If I or anyone else manages to figure out how to fix leanprover/lean4#2267 then both variants will come out the same. |
|
It seems like you can find a few more with |
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Thanks!
All my comments are optional, and are fine in a follow-up PR if you just want to get this merged before it goes stale.
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
|
I read through the 4k hits of |
|
bors merge |
|
Merge conflict. |
|
bors merge |
I used the regex `\(\(· (.) ·\) (.)\)`, replacing with `($2 $1 ·)`.
|
Pull request successfully merged into master. Build succeeded: |
(· op ·) a by (a op ·)(· op ·) a by (a op ·)
I used the regex `\(\(· (.) ·\) (.)\)`, replacing with `($2 $1 ·)`.
I used the regex
\(\(· (.) ·\) (.)\), replacing with($2 $1 ·).