Skip to content

[Merged by Bors] - feat: extend results on product measures from sigma-finite to s-finite measures#8713

Closed
sgouezel wants to merge 13 commits intomasterfrom
SG_sfinite_prod
Closed

[Merged by Bors] - feat: extend results on product measures from sigma-finite to s-finite measures#8713
sgouezel wants to merge 13 commits intomasterfrom
SG_sfinite_prod

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor


Open in Gitpod

@sgouezel sgouezel added awaiting-review t-measure-probability Measure theory / Probability theory labels Nov 29, 2023
@urkud
Copy link
Copy Markdown
Member

urkud commented Nov 29, 2023

I'll come to the office in ~40min and review from there.

classical
obtain ⟨f, hf⟩ : ∃ f : ι → ℕ, Function.Injective f := Countable.exists_injective_nat ι
let e : ι ≃ range f := Equiv.ofInjective f hf
let m' : ℕ → Measure α := fun n ↦ if hn : n ∈ range f then m (e.symm ⟨n, hn⟩) else 0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 2 ways to move parts of this proof to reusable lemmas.

  • Add Measure.sum_comp_equiv, instances for IsFiniteMeasure (∑ i, f i) and [Finite ι] : IsFiniteMeasure (.sum f), then treat [Finite ι] and [Infinite ι] separately.
  • Add Measure.sum_extend_zero using Function.extend instead of the equivalent definition you use, then apply it.

Maybe, we should have all these supporting lemmas/instances.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added Measure.sum_comp_equiv and Measure.sum_extend_zero. Indeed, the proof becomes nicer with these! On the other hand, I don't think that splitting into finite or infinite \iota would make things nicer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generalized sum_extend_zero and Function.apply_extend.
bors d+

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 29, 2023
@sgouezel sgouezel added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 30, 2023
sgouezel and others added 5 commits November 30, 2023 09:24
- `Function.apply_extend` doesn't need any assumptions on `f`.
- Add `tsum_extend_zero`.
- Generalize `sum_extend_zero` to any injective function, not just
  `Subtype.val`.
- Use it to golf `sfinite_sum_of_countable`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 1, 2023

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sgouezel
Copy link
Copy Markdown
Contributor Author

sgouezel commented Dec 1, 2023

bors r+
Thanks for the review and for the golf!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 1, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 1, 2023
…e measures (#8713)

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
mathlib-bors bot pushed a commit that referenced this pull request Dec 1, 2023
…e measures (#8713)

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 1, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: extend results on product measures from sigma-finite to s-finite measures [Merged by Bors] - feat: extend results on product measures from sigma-finite to s-finite measures Dec 1, 2023
@mathlib-bors mathlib-bors bot closed this Dec 1, 2023
@mathlib-bors mathlib-bors bot deleted the SG_sfinite_prod branch December 1, 2023 09:49
awueth pushed a commit that referenced this pull request Dec 19, 2023
…e measures (#8713)

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants